thomasrebele commented on code in PR #6237:
URL: https://github.com/apache/hive/pull/6237#discussion_r2695127428
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java:
##########
@@ -280,20 +280,20 @@ private boolean selectJoinForLlap(OptimizeTezProcContext
context, JoinOperator j
continue;
}
Operator<? extends OperatorDesc> parentOp =
joinOp.getParentOperators().get(pos);
- totalSize += computeOnlineDataSize(parentOp.getStatistics());
+ totalSize = StatsUtils.safeAdd(totalSize,
computeOnlineDataSize(parentOp.getStatistics()));
Review Comment:
I think it's fine. The total size here does not need to be 100% correct,
it's just an estimation that influences the join decision. Might make sense to
rename it to `estimatedTotalSize`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
