ramitg254 commented on code in PR #6259:
URL: https://github.com/apache/hive/pull/6259#discussion_r2710939638
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergTableUtil.java:
##########
@@ -567,6 +567,17 @@ public static List<String> getPartitionNames(Table table,
Map<String, String> pa
}
}
+ public static boolean hasPartition(Table icebergTable,
+ Map<String, String> partitionSpec) throws
MetaException {
+ try {
+ List<String> partNames = getPartitionNames(icebergTable, partitionSpec,
false);
+ return !partNames.isEmpty() &&
+ Warehouse.makePartName(partitionSpec,
false).equals(partNames.getFirst());
Review Comment:
done, used the snippet just a change was needed in the snippet needed to
move
```
List<String> partNames =
getPartitionNames(conf, table, partitionSpec, false);
if (partNames.isEmpty()) {
return null;
}
```
inside try block as well as it can throw :
```
Caused by: org.apache.hadoop.hive.ql.parse.SemanticException: No partition
column by the name: pcol
at
org.apache.iceberg.mr.hive.IcebergTableUtil.generateExpressionFromPartitionSpec
```
from `generateExpressionFromPartitionSpec `in `getPartitionNames` when
executed`explain insert` queries so needed to catch that exception and return
null as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
