deniskuzZ commented on code in PR #6259:
URL: https://github.com/apache/hive/pull/6259#discussion_r2715498035
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java:
##########
@@ -1345,7 +1348,14 @@ public TableSpec(Hive db, HiveConf conf, ASTNode ast,
boolean allowDynamicPartit
if (partHandle == null) {
// if partSpec doesn't exists in DB, return a delegate one
// and the actual partition is created in MoveTask
- partHandle = new Partition(tableHandle, partSpec, null);
+ try {
+ partHandle = tableHandle.hasNonNativePartitionSupport() ?
+ new DummyPartition(tableHandle,
Warehouse.makePartName(partSpec, false), partSpec) :
Review Comment:
1. consider extracting into separate method: getPartitioHandle?
2. in case off partition transform `DummyPartition#name` would be different:
won't be transformed as in exists scenario, isn't it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
