deniskuzZ commented on code in PR #6259:
URL: https://github.com/apache/hive/pull/6259#discussion_r2719635855
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/info/desc/DescTableOperation.java:
##########
@@ -127,7 +127,7 @@ private Table getTable() throws HiveException {
private Partition getPartition(Table table) throws HiveException {
Partition part = null;
if (desc.getPartitionSpec() != null) {
- part = context.getDb().getPartition(table, desc.getPartitionSpec(),
false);
+ part = context.getDb().getPartition(table, desc.getPartitionSpec());
Review Comment:
why are we calling `db.getPartition` multiple times? first in
DescTableAnalyzer and then here. can we forward it from `DescTableAnalyzer` to
`DescTableOperation` through the `DescTableDesc` instead of `partitionSpec`?
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/info/desc/DescTableOperation.java:
##########
@@ -127,7 +127,7 @@ private Table getTable() throws HiveException {
private Partition getPartition(Table table) throws HiveException {
Partition part = null;
if (desc.getPartitionSpec() != null) {
- part = context.getDb().getPartition(table, desc.getPartitionSpec(),
false);
+ part = context.getDb().getPartition(table, desc.getPartitionSpec());
Review Comment:
why are we calling `db.getPartition` multiple times? first in
DescTableAnalyzer and then here.
can we forward it from `DescTableAnalyzer` to `DescTableOperation` through
the `DescTableDesc` instead of `partitionSpec`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
