deniskuzZ commented on code in PR #6259:
URL: https://github.com/apache/hive/pull/6259#discussion_r2720716547
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/DummyPartition.java:
##########
@@ -60,6 +63,14 @@ public DummyPartition(Table tbl, String name, Map<String,
String> partSpec) {
this.partSpec = Maps.newLinkedHashMap(partSpec);
setTPartition(tPart);
+
+ Table table = this.getTable();
Review Comment:
@ramitg254, you have tbl in constructor arg, this is redundant.
please make it lazy. they are not always used.
````
@Override
public List<String> getValues() {
if (values != null) {
return values;
}
Table table = this.getTable();
values = new ArrayList<>();
for (FieldSchema fs : table.hasNonNativePartitionSupport()
? table.getStorageHandler().getPartitionKeys(table)
: table.getPartCols()) {
String val = partSpec.get(fs.getName());
values.add(val);
}
return values;
}
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
