abstractdog commented on PR #6317:
URL: https://github.com/apache/hive/pull/6317#issuecomment-3913365332
I believe this patch is fine now, LGTM
In the long run, we might want to find a way to get the distinct TableDesc
objects from a MapWork (TODO: could be more than 1?), which also means
rethinking of this method:
```
public Map<String, PartitionDesc> getAliasToPartnInfo() {
return aliasToPartnInfo;
}
```
which a bad public getter for a mutable collection, also it's setter
counterpart `setAliasToPartnInfo` is not used
I created https://issues.apache.org/jira/browse/HIVE-29464 as a followup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
