abstractdog commented on code in PR #6321:
URL: https://github.com/apache/hive/pull/6321#discussion_r2815922060
##########
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/dbinstall/rules/DatabaseRule.java:
##########
@@ -19,11 +19,15 @@
import org.apache.hadoop.hive.metastore.tools.schematool.MetastoreSchemaTool;
import org.junit.rules.ExternalResource;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
/**
* Abstract JUnit TestRule for different RDMBS types.
*/
public abstract class DatabaseRule extends ExternalResource {
+ private static final Logger LOG =
LoggerFactory.getLogger(DatabaseRule.class);
Review Comment:
oh, good to know about SneakyThrows!
you know, I'm just bothered that IDEA shows that those kinds of exceptions
are now thrown, I believe if we already faked the compiler, it doesn't make
sense to add these to the method signature, it just makes the code vague (once
the exceptions will come at runtime, we're going to face them anyway)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
