okumin commented on code in PR #97: URL: https://github.com/apache/hive-site/pull/97#discussion_r2837139078
########## content/Development/desingdocs/hbase-execution-plans-for-rawstore-partition-filter-condition.md: ########## @@ -129,6 +129,7 @@ Examples of conversion of query plan to hbase api calls | Filter expression | HBase calls | +|---|---| Review Comment: Why do we use not a single but a triple dash? ########## content/Development/desingdocs/column-statistics-in-hive.md: ########## @@ -209,4 +214,4 @@ bool delete_partition_column_statistics(1:string db_name, 2:string tbl_name, 3:s Note that delete_column_statistics is needed to remove the entries from the metastore when a table is dropped. Also note that currently Hive doesn’t support drop column. Note that in V1 of the project, we will support only scalar statistics. Furthermore, we will support only static partitions, i.e., both the partition key and partition value should be specified in the analyze command. In a following version, we will add support for height balanced histograms as well as support for dynamic partitions in the analyze command for column level statistics. - +``` Review Comment: Should this be at L213? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
