zabetak commented on PR #6293: URL: https://github.com/apache/hive/pull/6293#issuecomment-3943243552
Hey @thomasrebele , I was going over the PR and did some refactoring to help me understand better some parts of the code and hopefully and improve a bit readability. My refactoring work can be found in the https://github.com/zabetak/hive/tree/HIVE-29424-r1 branch. However, after replacing the `FloatInterval` with Guava's `Range` API in commit https://github.com/apache/hive/commit/ef8dc6c9310845019e74e9478653fc6d24e32412 some tests in `TestFilterSelectivityEstimator` started failing cause it appears that some ranges are invalid. Specifically, the `adjustTypeBoundaries` creates a strange/invalid range (i.e., `(100.049995..99.94999]`) when `rangeBoundaries` is `(100.0..Infinity]` and type is `DECIMAL(3, 1)`; it is strange to have a range/interval with a lower bound (`100.049995`) greater than the upper bound (`99.94999`) so wanted to check with you if that behavior is expected/intentional. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
