soumyakanti3578 commented on code in PR #6350:
URL: https://github.com/apache/hive/pull/6350#discussion_r2907050243
##########
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java:
##########
@@ -3958,4 +3958,58 @@ public void testDropDataConnectorIfNotExistsTrue()
throws Exception {
// No such data connector, ignore NoSuchObjectException
client.dropDataConnector("no_such_data_connector", true, false);
}
+
+ /**
+ * Test for storage-based SerDes (AvroSerDe, HBaseSerDe).If the SerDe is not
listed in
+ * SERDES_USING_METASTORE_FOR_SCHEMA, HMS falls through to
DefaultStorageSchemaReader and throws
+ * "Storage schema reading not supported".
+ */
+ @Test
+ public void testGetFieldsForStorageSerDes() throws Exception {
Review Comment:
We should probably divide this into two tests for the two SerDes as they are
completely different and not related to each other. Also, the comment above
should be edited accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
