deniskuzZ commented on code in PR #6314:
URL: https://github.com/apache/hive/pull/6314#discussion_r2915026830


##########
ql/src/test/org/apache/hadoop/hive/metastore/txn/TestCompactionTxnHandler.java:
##########
@@ -719,8 +719,10 @@ public void testFindPotentialCompactions() throws 
Exception {
 
     List<LockComponent> components = new ArrayList<>();
 
-    components.add(createLockComponent(LockType.SHARED_WRITE, LockLevel.DB, 
"mydb", "mytable", null, DataOperationType.UPDATE));
-    components.add(createLockComponent(LockType.SHARED_WRITE, LockLevel.DB, 
"mydb", "yourtable", "mypartition=myvalue", DataOperationType.UPDATE));
+    components.add(createLockComponent(LockType.SHARED_WRITE, LockLevel.DB, 
"hive", "mydb",

Review Comment:
   i don't have strong preference, however, i think catalog param is redundant 
here as this in not a multi-catalog test



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to