zhangbutao commented on code in PR #6267: URL: https://github.com/apache/hive/pull/6267#discussion_r2923472640
########## standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/CatalogUtil.java: ########## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hive.metastore; + +import org.apache.commons.lang3.EnumUtils; + +import java.util.EnumSet; +import java.util.Set; + +public class CatalogUtil { + public enum CatalogType { + NATIVE, Review Comment: > NATIVE means Hive only? Not quite accurate. Strictly speaking, NATIVE refers to multiple Hive-type catalogs within the same HMS. NATIVE-type catalogs belong to the same HMS. hive type catalogs, on the other hand, are catalogs created within one HMS that point to another HMS. This means we can use a single HS2 to perform federated queries across data from multiple different HMS instances. > if we plan to support federation won't REMOTE be a better choice instead of ICEBERG? Iceberg is a table type For Iceberg type catalogs, I primarily refer to StarRocks' definition, where the type is set to "iceberg", and this Iceberg catalog is controlled by another parameter "iceberg.catalog.type", which can be configured as either "hive" or other types (such as rest, etc.). Here is the reference: ``` CREATE EXTERNAL CATALOG iceberg_catalog_hms PROPERTIES ( "type" = "iceberg", "iceberg.catalog.type" = "hive", "hive.metastore.uris" = "thrift://xx.xx.xx.xx:9083", "aws.s3.use_instance_profile" = "true", "aws.s3.region" = "us-west-2" ); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
