saihemanth-cloudera commented on code in PR #6311:
URL: https://github.com/apache/hive/pull/6311#discussion_r2927542450
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java:
##########
@@ -3252,21 +3105,17 @@ public boolean drop_partition_req(final
DropPartitionRequest dropPartitionReq) t
String catName = dropPartitionReq.getCatName();
String tbl_name = dropPartitionReq.getTblName();
List<String> part_vals = dropPartitionReq.getPartVals();
- boolean ret = false;
- Exception ex = null;
try {
- Table t = getMS().getTable(catName, dbName, tbl_name, null);
+ Table t = getMS().getTable(catName, dbName, tbl_name, null);
if (t == null) {
- throw new InvalidObjectException(dbName + "." + tbl_name
- + " table not found");
+ throw new InvalidObjectException(dbName + "." + tbl_name + " table not
found");
}
List<String> partNames = new ArrayList<>();
if (part_vals == null || part_vals.isEmpty()) {
part_vals = getPartValsFromName(t, dropPartitionReq.getPartName());
}
partNames.add(Warehouse.makePartName(t.getPartitionKeys(), part_vals));
- startPartitionFunction("drop_partition_req", catName, dbName, tbl_name,
part_vals);
- LOG.info("Partition values: {}", part_vals);
+ LOG.info("drop_partition_req partition values: {}", part_vals);
Review Comment:
nit: can we also log dbname and tablename?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
