Neer393 commented on code in PR #6371: URL: https://github.com/apache/hive/pull/6371#discussion_r2958087736
########## ql/src/test/queries/clientpositive/hive_27193.q: ########## @@ -0,0 +1,6 @@ +CREATE DATABASE `@test`; +USE `@test`; +CREATE TABLE testtable (c1 INT); +ALTER TABLE testtable ADD COLUMNS (c2 INT); Review Comment: > In this case @hive#test the whole word is database or it is deciphered as catalog#database. The purpose is to check with @ as per the kita. It is deciphered as `@catalog#database` So as per this JIRA, ALTER TABLE queries are failing because they call the `MetastoreUtils.parseDbName()` method which is calling the `MetastoreUtils.hasCatalogName()` method which you have fixed but the purpose of parseDbName is that it should return an array of size 2 where the 1st element is catalog name and the 2nd element is the database name. So just to make sure both with and without catalog name works, I have asked you to run both queries -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
