soumyakanti3578 commented on code in PR #6361:
URL: https://github.com/apache/hive/pull/6361#discussion_r2966748673
##########
service/src/java/org/apache/hive/service/cli/operation/ExecuteStatementOperation.java:
##########
@@ -45,13 +45,7 @@
public abstract class ExecuteStatementOperation extends Operation {
protected String statement = null;
- public ExecuteStatementOperation(HiveSession parentSession, String statement,
- Map<String, String> confOverlay) {
- super(parentSession, confOverlay, OperationType.EXECUTE_STATEMENT);
- this.statement = statement;
- }
-
- public ExecuteStatementOperation(HiveSession parentSession, String
statement, Map<String, String> confOverlay, boolean runInBackground, boolean
generateNewQueryId) {
+ public ExecuteStatementOperation(HiveSession parentSession, String
statement, Map<String, String> confOverlay, boolean generateNewQueryId) {
Review Comment:
nit: Do you think the variable `generateNewQueryId` is confusing? Everywhere
else in its hierarchy the variable is named `embedded`, i.e., in `Operation`
and in this PR you're adding `embedded` to `HiveCommandOperation` and
`ShowProcessListOperation` too. Although, I think the name `embedded` itself is
quite confusing, but at least it is used consistently, except here.
I am adding just a nit here because this was not introduced in this PR, but
if this bugs you too please rename this.
P.S.: What do you think about renaming `embedded` to `isHplSqlMode`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
