deniskuzZ commented on code in PR #6379:
URL: https://github.com/apache/hive/pull/6379#discussion_r3071265542
##########
llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestCacheContentsTracker.java:
##########
@@ -127,7 +130,7 @@ public void testCacheTagComparison() {
public void testEncodingDecoding() throws Exception {
LinkedHashMap<String, String> partDescs = new LinkedHashMap<>();
partDescs.put("pytha=goras", "a2+b2=c2");
- CacheTag tag = CacheTag.build("math.rules", partDescs);
+ CacheTag tag = CacheTag.build(Warehouse.DEFAULT_CATALOG_NAME +
".math.rules", partDescs);
Review Comment:
ok, got it. In that case, won't it be better to pass it as a separate arg?
````
CacheTag.build(Warehouse.DEFAULT_CATALOG_NAME, "math.rules", partDescs)
````
maybe not...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
