deniskuzZ commented on code in PR #6436:
URL: https://github.com/apache/hive/pull/6436#discussion_r3099430858
##########
llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java:
##########
@@ -454,9 +454,9 @@ public LlapTaskSchedulerService(TaskSchedulerContext
taskSchedulerContext, Clock
this.pauseMonitor = new JvmPauseMonitor(conf);
pauseMonitor.start();
String displayName = "LlapTaskSchedulerMetrics-" +
MetricsUtils.getHostName();
- String sessionId = conf.get("llap.daemon.metrics.sessionid");
- // TODO: Not sure about the use of this. Should we instead use
workerIdentity as sessionId?
- this.metrics = LlapTaskSchedulerMetrics.create(displayName, sessionId);
+ String metricsSessionId = conf.get("llap.daemon.metrics.sessionid");
Review Comment:
i would revert the `metricsSessionId` change then, but i'll leave it up to
you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
