kokila-19 opened a new pull request, #6439:
URL: https://github.com/apache/hive/pull/6439

   …ified column names when they are function names(like date)
   
   
   ### What changes were proposed in this pull request?
   During merge rewrite, quote the qualified identifiers when those identifiers 
are same as function name.
   
   ### Why are the changes needed?
   Hive rewrites a MERGE into a different SQL statement (typically INSERT, 
SELECT) and then parses the rewritten SQL again.
   That rewritten SQL is produced from the AST.
   After [HIVE-29187](https://issues.apache.org/jira/browse/HIVE-29187), the 
unparse logic does not quote any identifier that matches a built‑in function 
name.
   
   So when the rewritten query contains a qualified reference like: s.date the 
unparse step must regenerate it as: 's' .'date'
   Instead, it was 's'.date
   Because it was not quoted, it fails to parse when the rewritten query is 
compiled.
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   ### How was this patch tested?
   
   `mvn test -pl itests/qtest -Dtest=TestMiniLlapLocalCliDriver 
-Dqfile=sqlmerge.q -Dtest.output.overwrite=true -Pitests
   `


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to