ramitg254 commented on code in PR #6376:
URL: https://github.com/apache/hive/pull/6376#discussion_r3122205926
##########
ql/src/java/org/apache/hadoop/hive/ql/cache/results/QueryResultsCache.java:
##########
@@ -549,6 +578,39 @@ public boolean setEntryValid(CacheEntry cacheEntry,
FetchWork fetchWork) {
return false;
}
+ if (isSafeCacheWriteEnabled) {
Review Comment:
done moved to rewriteFetchWorkForSafeCacheWrite method
##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -5670,7 +5670,9 @@ public static enum ConfVars {
HIVE_QUERY_RESULTS_CACHE_ENABLED("hive.query.results.cache.enabled", true,
"If the query results cache is enabled. This will keep results of
previously executed queries " +
"to be reused if the same query is executed again."),
-
+
HIVE_QUERY_RESULTS_SAFE_CACHE_WRITE_ENABLED("hive.query.results.safe.cache.write.enabled",
false,
Review Comment:
done corrected order
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
