deniskuzZ commented on code in PR #6267:
URL: https://github.com/apache/hive/pull/6267#discussion_r3137343191
##########
itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestMiniClusters.java:
##########
@@ -554,23 +556,27 @@ private void setFsRelatedProperties(HiveConf conf,
boolean isLocalFs, FileSystem
// Create a fake fs root for local fs
Path localFsRoot = new Path(path, "localfs");
warehousePath = new Path(localFsRoot, "warehouse");
+ warehouseCatPath = new Path(localFsRoot, "catalog");
Review Comment:
@zhangbutao
> The warehousePath is the path of the default catalog, under which the
paths of Hive databases reside. If the catalog path is placed under the
warehousePath, it will cause confusion with the path information of Hive
databases under the default catalog.
i don't get that at all. where is confusion
[here](https://github.com/apache/hive/pull/6267#discussion_r3068019699)?
> The path for non-default catalogs is controlled by the new added property
metastore.warehouse.catalog.dir
i don't think we need additional config for that
@dengzhhu653
> I don't like to add a new metastore.warehouse.catalog.dir as a default
location for new catalogs(non-default). this could bring some concerns IMO
I'm aligned on this as well
+1
> On creating the catalog, we create the default database as well, the
default database will stay at the old location even if we change the location
of the catalog
default DB location should be under it's catalog location IMO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
