thomasrebele commented on code in PR #6422:
URL: https://github.com/apache/hive/pull/6422#discussion_r3152727003


##########
hplsql/src/main/java/org/apache/hive/hplsql/Stmt.java:
##########
@@ -1082,7 +1085,7 @@ else if (trace) {
               trace(ctx, "Variable not found: " + ctx.L_ID(i).getText());
             }
           }
-          exec.setSqlCode(SqlCodes.SUCCESS);
+          exec.setSqlSuccess();

Review Comment:
   Do we need to call `setSqlSuccess()` again? As far as I understand the code, 
the SQL code or state are now overwritten by the previous commands.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to