henrib commented on code in PR #6425:
URL: https://github.com/apache/hive/pull/6425#discussion_r3155262908
##########
standalone-metastore/metastore-rest-catalog/src/main/java/org/apache/iceberg/rest/HMSCatalogAdapter.java:
##########
Review Comment:
May be also reduce exception verbosity:
```
public static void configureResponseFromException(
Exception exc, ErrorResponse.Builder errorBuilder) {
int errorCode = EXCEPTION_ERROR_CODES.getOrDefault(exc.getClass(), 500);
errorBuilder
.responseCode(errorCode)
.withType(exc.getClass().getSimpleName())
.withMessage(exc.getMessage());
// avoid exposing stack traces for client errors, but include them for
server errors to aid debugging
if (errorCode == 500) {
errorBuilder.withStackTrace(exc);
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
