deniskuzZ commented on code in PR #6458:
URL: https://github.com/apache/hive/pull/6458#discussion_r3169270118
##########
standalone-metastore/metastore-rest-catalog/src/main/java/org/apache/iceberg/rest/HMSCatalogFactory.java:
##########
@@ -112,7 +112,13 @@ private HttpServlet createServlet(Catalog catalog) {
// Iceberg REST client uses "catalog" by default
List<String> scopes = Collections.singletonList("catalog");
ServletSecurity security = new
ServletSecurity(AuthType.fromString(authType), configuration, req -> scopes);
- return security.proxy(new HMSCatalogServlet(new
HMSCatalogAdapter(catalog)));
+ final IcebergVendedCredentialProvider vendedCredentialProvider;
+ if (MetastoreConf.getBoolVar(configuration,
ConfVars.ICEBERG_CATALOG_VENDED_CREDENTIALS_ENABLED)) {
+ vendedCredentialProvider = new
IcebergVendedCredentialProvider(configuration);
+ } else {
+ vendedCredentialProvider = null;
Review Comment:
do we need else? maybe simply drop final?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
