VenuReddy2103 commented on code in PR #6459:
URL: https://github.com/apache/hive/pull/6459#discussion_r3193295861
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/handler/DropDatabaseHandler.java:
##########
@@ -137,9 +136,6 @@ public DropDatabaseResult execute() throws TException,
IOException {
if (isSoftDelete) {
context = new EnvironmentContext();
context.putToProperties(hive_metastoreConstants.TXN_ID,
String.valueOf(request.getTxnId()));
- if (ReplChangeManager.isSourceOfReplication(db)) {
Review Comment:
Yes it is redundant to set here since we set in `DropTableHandler`. And it
need to present in `DropTableHandler`. When drop soft table is followed by drop
database cascade, we won't preseve this info in `CQ_TBLPROPERTIES` if we do not
set in `DropTableHandler`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
