soumyakanti3578 commented on code in PR #6438:
URL: https://github.com/apache/hive/pull/6438#discussion_r3197815906
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
##########
@@ -1291,6 +1291,21 @@ public enum ConfVars {
"metastore.partition.management.table.pattern", "*",
"Automatic partition management will look for tables using the specified
table pattern"),
+
STATISTICS_MANAGEMENT_TASK_FREQUENCY("metastore.statistics.management.task.frequency",
+ "metastore.statistics.management.task.frequency",
+ 7, TimeUnit.DAYS, "Frequency at which timer task runs to do
automatic statistics \n" +
+ "management for tables. Statistics management include 2 configs.
\n" +
+ "One is 'statistics.auto.deletion', and the other is
'metastore.statistics.retention.period'. \n" +
+ "When 'statistics.auto.deletion'='true' is set, statistics
management will look for tables which their\n " +
+ "column statistics are over the retention period, and then delete
the column stats. \n"),
+ STATISTICS_RETENTION_PERIOD("metastore.statistics.retention.period",
+ "metastore.statistics.retention.period", 365, TimeUnit.DAYS, "The
retention period " +
+ "that we want to keep the stats for each table, which means if the
stats are older than this period\n" +
+ "of time, the stats will be automatically deleted. \n"),
+
+ STATISTICS_AUTO_DELETION("metastore.statistics.auto.deletion",
"metastore.statistics.auto.deletion", false,
+ "Whether table/partition column statistics will be auto deleted
after retention period"),
Review Comment:
Are these properties only for column stats? If yes, then maybe its better to
rename them to `COLUMN_STATISTICS_AUTO_DELETION`, etc, and similarly the actual
property can be `metastore.column.statistics.retention.period`.
What do you think?
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
##########
@@ -1291,6 +1291,21 @@ public enum ConfVars {
"metastore.partition.management.table.pattern", "*",
"Automatic partition management will look for tables using the specified
table pattern"),
+
STATISTICS_MANAGEMENT_TASK_FREQUENCY("metastore.statistics.management.task.frequency",
+ "metastore.statistics.management.task.frequency",
Review Comment:
The first two arguments are the same. Should the second one (`hiveName`) be
something else, like, `hive.column.statistics.management.task.frequency`? Not
sure if it even matters tbh.
Similar issue for the other two props too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
