kuczoram commented on code in PR #6470:
URL: https://github.com/apache/hive/pull/6470#discussion_r3225044568
##########
storage-api/src/java/org/apache/hadoop/hive/common/ValidCleanerWriteIdList.java:
##########
@@ -49,4 +50,17 @@ public RangeResponse isWriteIdRangeValid(long minWriteId,
long maxWriteId) {
}
return super.isWriteIdRangeValid(minWriteId, maxWriteId);
}
+
+ /**
+ * Only consider the writeIds below the highWaterMark. This is to prevent
the cleaner
+ * from deleting above its highWaterMark, even in case of aborted
directories.
+ * otherwise uses {@link ValidReaderWriteIdList#isWriteIdAborted(long)}
+ */
+ @Override
+ public boolean isWriteIdAborted(long writeId) {
+ if (writeId > highWatermark) {
Review Comment:
Fortunately isWriteIdRangeAborted already contains check against the
highWaterMark
if (highWatermark < minWriteId) {
return RangeResponse.NONE;
}
In isWriteIdAborted I think it is indeed another bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
