Aggarwal-Raghav commented on PR #6443: URL: https://github.com/apache/hive/pull/6443#issuecomment-4475544175
> > Hi @Aggarwal-Raghav Thanks for pointing it out & yes, this is definitely better for optimisation. I have refactored the same in commit [37d1c22](https://github.com/apache/hive/pull/6443/commits/37d1c2267a120a76d37e214c5e968ee2d2ef859e) > > > > CC: @abstractdog > > commit looks good to me and looks like it's addressing the optimization idea, which is good, so my approval still holds: please let us know @Aggarwal-Raghav if you're okay with the patch now Hey, please proceed. I've reviewed the Java specific changes, and the comments appear to have been addressed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
