InvisibleProgrammer commented on code in PR #6487:
URL: https://github.com/apache/hive/pull/6487#discussion_r3274120820
##########
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCrudCompactorOnTez.java:
##########
@@ -642,15 +167,15 @@ public void
secondCompactionShouldBeRefusedBeforeEnqueueing() throws Exception {
} catch (CommandProcessorException e) {
String errorMessage = ErrorMsg.COMPACTION_REFUSED.format(dbName,
tableName, "",
"Compaction is already scheduled with state='ready for cleaning' and
id=" + resp.getId());
- Assert.assertEquals(errorMessage, e.getCauseMessage());
- Assert.assertEquals(ErrorMsg.COMPACTION_REFUSED.getErrorCode(),
e.getErrorCode());
+ assertEquals(errorMessage, e.getCauseMessage());
+ assertEquals(ErrorMsg.COMPACTION_REFUSED.getErrorCode(),
e.getErrorCode());
Review Comment:
Errr... Sure. Let me check this. I suppose I have to reduce my IDE's
capabilities and it can be done. Honestly, I just removed some code blocks from
this class. Those changes were handled by the IDE and I didn't even notice
them.
However, I think the official guideline is a little bit obsolete: I'm pretty
sure I saw a discussion somewhere about the opposite, like please do not do
trivial changes like small reformats, formatting, etc to reduce the load on the
precommit jobs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
