deniskuzZ commented on code in PR #6485:
URL: https://github.com/apache/hive/pull/6485#discussion_r3324118058
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/lineage/ExprProcFactory.java:
##########
@@ -183,13 +183,14 @@ public static SemanticNodeProcessor getColumnProcessor() {
return new ColumnExprProcessor();
}
- private static boolean findSourceColumn(
+ private static boolean findSourceColumn(Operator<? extends OperatorDesc>
inpOp,
LineageCtx lctx, Predicate cond, String tabAlias, String alias) {
for (Map.Entry<String, TableScanOperator> topOpMap:
lctx.getParseCtx().getTopOps().entrySet()) {
TableScanOperator tableScanOp = topOpMap.getValue();
Table tbl = tableScanOp.getConf().getTableMetadata();
- if (tbl.getTableName().equals(tabAlias)
- || tabAlias.equals(tableScanOp.getConf().getAlias())) {
+ if (inpOp.getOperatorId().equals(tableScanOp.getOperatorId())
Review Comment:
would it make sense to extract if condition in a helper match method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
