Copilot commented on code in PR #6525:
URL: https://github.com/apache/hive/pull/6525#discussion_r3369270247
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/DynamicPartitionPruningOptimization.java:
##########
@@ -302,7 +302,9 @@ private boolean
disableSemiJoinOptDueToExternalTable(HiveConf conf, TableScanOpe
boolean disableSemiJoin = false;
if
(conf.getBoolVar(HiveConf.ConfVars.HIVE_DISABLE_UNSAFE_EXTERNALTABLE_OPERATIONS))
{
// We already have the TableScan for one side of the join. Check this
now.
- if (!StatsUtils.checkCanProvideStats(new
Table(ts.getConf().getTableMetadata().getTTable()))) {
+ // Semijoin reduction is a runtime filter, so relying on (possibly
stale) stats only costs
+ // performance, not correctness - the relaxed check also accepts
analyzed external tables.
+ if (!StatsUtils.checkCanProvideStatsForOpt(new
Table(ts.getConf().getTableMetadata().getTTable()))) {
LOG.debug("Disabling semijoin optimzation on {} since it is an
external table and also could not provide statistics.",
ts.getConf().getTableMetadata().getFullyQualifiedName());
Review Comment:
Typo in log message: "optimzation" should be "optimization" for
readability/searchability in logs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
