ramitg254 commented on code in PR #6413:
URL: https://github.com/apache/hive/pull/6413#discussion_r3378843065
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java:
##########
@@ -916,6 +997,9 @@ public void setDbName(String databaseName) {
}
public List<FieldSchema> getPartitionKeys() {
+ if (tTable.getPartitionKeys() == null) {
Review Comment:
we shouldn't throw null from partition keys retrieval method and an empty
list in place of it.
This is the convention we were following in earlier getPartCols() and
getStorageHandler().getPartitionKeys().
It avoids unnecessary null checks at place of usage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
