ramitg254 commented on code in PR #6413:
URL: https://github.com/apache/hive/pull/6413#discussion_r3379864005
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/create/CreateTableOperation.java:
##########
@@ -161,7 +161,9 @@ private void createTableNonReplaceMode(Table tbl) throws
HiveException {
if (desc.isCTAS()) {
Table createdTable = context.getDb().getTable(tbl.getDbName(),
tbl.getTableName());
DataContainer dc = new DataContainer(createdTable.getTTable());
-
context.getQueryState().getLineageState().setLineage(createdTable.getPath(),
dc, createdTable.getCols());
+ context.getQueryState().getLineageState().setLineage(
+ createdTable.getPath(), dc,
createdTable.hasNonNativePartitionSupport() ?
Review Comment:
extraction to local variable is a nice idea but we need all cols here for
iceberg as partition cols in iceberg are actual cols part of row schema rather
than just partition keys which are stored in HMS which is case of native tables
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
