tanishq-chugh commented on code in PR #6528:
URL: https://github.com/apache/hive/pull/6528#discussion_r3387523891
##########
ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestZookeeperExternalSessionsRegistryClient.java:
##########
@@ -128,5 +134,118 @@ public void testReuseSameSession() throws Exception {
}
}
}
+
+ /**
+ * Tests that multiple registry clients (simulating multiple HS2 instances)
+ * respect the global distributed lock (claims) and do not claim the same
session simultaneously.
+ */
+ @Test
+ public void testSessionClaimsFromDifferentRegistryClients() throws Exception
{
+ CuratorFramework client = null;
+ ZookeeperExternalSessionsRegistryClient registry1 = null;
+ ZookeeperExternalSessionsRegistryClient registry2 = null;
+
+ try (TestingServer server = new TestingServer()) {
+ String connectString = server.getConnectString();
+
+ HiveConf conf = new HiveConf();
+ conf.setVar(ConfVars.HIVE_ZOOKEEPER_QUORUM, connectString);
+ conf.setVar(ConfVars.HIVE_SERVER2_TEZ_EXTERNAL_SESSIONS_NAMESPACE,
"/tez_ns_concurrent");
+
conf.setIntVar(ConfVars.HIVE_SERVER2_TEZ_EXTERNAL_SESSIONS_WAIT_MAX_ATTEMPTS,
5);
+
+ String namespace = HiveConf.getVar(conf,
ConfVars.HIVE_SERVER2_TEZ_EXTERNAL_SESSIONS_NAMESPACE);
+ String effectivePath =
ZookeeperExternalSessionsRegistryClient.normalizeZkPath(namespace);
+
+ CuratorFrameworkFactory.Builder builder =
CuratorFrameworkFactory.builder();
+ client = builder.connectString(connectString).retryPolicy(new
RetryOneTime(1)).build();
+ client.start();
+
+ client.create().creatingParentsIfNeeded().forPath(effectivePath +
"/app_1");
+ client.create().forPath(effectivePath + "/app_2");
+
+ registry1 = new ZookeeperExternalSessionsRegistryClient(conf);
+ registry2 = new ZookeeperExternalSessionsRegistryClient(conf);
+
+ String sessionFromRegistry1 = registry1.getSession();
+ String sessionFromRegistry2 = registry2.getSession();
+
+ assertNotNull("Registry 1 should have claimed a session",
sessionFromRegistry1);
+ assertNotNull("Registry 2 should have claimed a session",
sessionFromRegistry2);
+
+ assertNotEquals("The two registries should claim different sessions!",
+ sessionFromRegistry1, sessionFromRegistry2);
+
+ registry1.returnSession(sessionFromRegistry1);
+
+ String session3FromRegistry2 = registry2.getSession();
+ assertEquals("Registry 2 should be able to claim the newly released
session",
+ sessionFromRegistry1, session3FromRegistry2);
+
+ registry2.returnSession(sessionFromRegistry2);
+ registry2.returnSession(session3FromRegistry2);
+ } finally {
+ if (registry1 != null) {
+ registry1.close();
+ }
+ if (registry2 != null) {
+ registry2.close();
+ }
+ if (client != null) {
+ client.close();
+ }
+ }
+ }
+
+ /**
+ * Tests that the InterProcessMutex enforces strict Global FIFO ordering.
+ * Clients form a queue when no sessions are available, and are served in
exact order.
+ */
+ @Test
+ public void testFIFOSessionClaimsFromDifferentRegistries() throws Exception {
+ try (TestingServer server = new TestingServer()) {
+ String connectString = server.getConnectString();
+
+ HiveConf conf = new HiveConf();
+ conf.setVar(ConfVars.HIVE_ZOOKEEPER_QUORUM, connectString);
+ conf.setVar(ConfVars.HIVE_SERVER2_TEZ_EXTERNAL_SESSIONS_NAMESPACE,
"/tez_ns_fifo");
+
conf.setIntVar(ConfVars.HIVE_SERVER2_TEZ_EXTERNAL_SESSIONS_WAIT_MAX_ATTEMPTS,
15);
Review Comment:
Leftover, removed in commit:
[6bab8dc](https://github.com/apache/hive/pull/6528/commits/6bab8dc7c52abbb8a358279017f3a33a9031d122)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
