ramitg254 commented on code in PR #6413:
URL: https://github.com/apache/hive/pull/6413#discussion_r3406032801
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -2296,11 +2296,11 @@ public boolean
canPerformMetadataDelete(org.apache.hadoop.hive.ql.metadata.Table
@Override
public List<FieldSchema>
getPartitionKeys(org.apache.hadoop.hive.ql.metadata.Table hmsTable) {
- if (BaseHiveIcebergMetaHook.isIcebergView(hmsTable.getTTable())) {
- List<FieldSchema> partCols = hmsTable.getPartCols();
- return partCols != null ? partCols : Collections.emptyList();
+ if (BaseHiveIcebergMetaHook.isIcebergView(hmsTable.getTTable()) ||
+ !MetaStoreUtils.isIcebergTable(hmsTable.getParameters())) {
Review Comment:
both the methods are concerned with table params so moved them along with
combined helper to MetaStoreUtils
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
