tanishq-chugh commented on code in PR #6528:
URL: https://github.com/apache/hive/pull/6528#discussion_r3441192476
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/TezJobMonitor.java:
##########
@@ -499,6 +499,20 @@ public static void killRunningJobs() {
}
}
+ public static void killRunningDAGsForApplication(String applicationId) {
+ synchronized (shutdownList) {
+ for (DAGClient c : shutdownList) {
+ try {
+ if (applicationId.equals(c.getSessionIdentifierString())) {
+ c.tryKillDAG();
+ }
+ } catch (Exception e) {
+ LOG.error("Error while trying to kill running DAG on tez session
{}", applicationId);
+ }
Review Comment:
Addressed in
[da8314e](https://github.com/apache/hive/pull/6528/commits/da8314ebba31e67fef475bd32ea32ef7eb669d09)
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java:
##########
@@ -353,6 +353,20 @@ void returnSession(TezSession tezSessionState) {
+ " belongs to the pool. Put it back in");
defaultSessionPool.returnSession((TezSessionPoolSession)tezSessionState);
}
+
+ if (useExternalSessions) {
+ if (tezSessionState.getTezClient() != null
+ && tezSessionState.getTezClient().getAppMasterApplicationId() !=
null) {
+ try {
+ tezSessionState.close(false);
Review Comment:
Addressed in
[da8314e](https://github.com/apache/hive/pull/6528/commits/da8314ebba31e67fef475bd32ea32ef7eb669d09)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
