deniskuzZ commented on code in PR #6413:
URL: https://github.com/apache/hive/pull/6413#discussion_r3452989298
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java:
##########
@@ -728,8 +750,50 @@ private boolean isField(String col) {
return false;
}
+ private void ensureColumnsIndexed() {
Review Comment:
`nameToIndexedColumn` is weird
please either rename to `columnsByName`, builder `indexColumnsByName()`,
getter `lazyColumnsByName()`
or if you'd like to keep `index`, then I would propose
`columnIndex`, builder `buildColumnIndex()`, getter `lazyColumnIndex()`
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java:
##########
@@ -728,8 +750,50 @@ private boolean isField(String col) {
return false;
}
+ private void ensureColumnsIndexed() {
Review Comment:
`nameToIndexedColumn` is weird
please either rename to `columnsByName`, builder `indexColumnsByName()`,
getter `lazyColumnsByName()`
or if you'd like to keep `index`, then I would propose
`columnIndex`, builder `buildColumnIndex()`, getter `lazyColumnIndex()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
