ramitg254 commented on code in PR #6565: URL: https://github.com/apache/hive/pull/6565#discussion_r3489857292
########## iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/DefaultMetadataPolicy.java: ########## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.hive; + +/** + * Controls which Iceberg schema default metadata is embedded when converting Hive types. + * + * <p>ORC tables use {@link #WRITE_DEFAULT} because initial-default is applied via + * {@code updateColumnDefault} at the schema-update layer. Other file formats use + * {@link #WRITE_AND_INITIAL_DEFAULT} for V3 column defaults. + */ +public enum DefaultMetadataPolicy { + WRITE_DEFAULT, + WRITE_AND_INITIAL_DEFAULT +} Review Comment: yes, corrected it avoided passing this argument and applied initial defaults to struct via a method created in HiveSchemaUtil.java (Earlier, I was trying to apply intial defualts directly in convert internal step so introduced this enum because passing isOrc boolean value as a method argument to the existing methods doesn't seem right so introduced this new argument to describe the purpose of adding this argument more clearly ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
