ashniku commented on code in PR #6412:
URL: https://github.com/apache/hive/pull/6412#discussion_r3557521263
##########
service/src/java/org/apache/hive/service/cli/operation/Operation.java:
##########
@@ -202,6 +202,14 @@ public long getNumModifiedRows() {
}
protected void setOperationException(HiveSQLException operationException) {
+ if (state == OperationState.TIMEDOUT) {
+ return;
+ }
+ // Do not overwrite a completed outcome (success, cancel, etc.). ERROR is
excluded so the
+ // background thread can still record the SQLException after runQuery()
sets ERROR.
+ if (state.isTerminal() && state != OperationState.ERROR) {
Review Comment:
Removed the synchronized block — timeoutExecutor is single-threaded and we
don’t synchronize elsewhere on this path; the isTerminal() check plus
setOperationException() guard is enough.
Dropped the explicit TIMEDOUT check — it was redundant since TIMEDOUT is
terminal and already covered by state.isTerminal() && state !=
OperationState.ERROR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
