saihemanth-cloudera commented on code in PR #6610:
URL: https://github.com/apache/hive/pull/6610#discussion_r3597757400
##########
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/AuthorizationMetaStoreFilterHook.java:
##########
@@ -56,43 +59,88 @@ public List<String> filterTableNames(String catName, String
dbName, List<String>
return getFilteredObjectNames(getFilteredObjects(listObjs));
}
+ /**
+ * Filters the given list of tables down to those the current user is
authorized to see.
+ *
+ * <p>The method delegates authorization decisions to {@link
HiveAuthorizer#filterListCmdObjects},
Review Comment:
filterTableMetas() and HiveMetaStoreAuthorizer already use
TablePrivilegeLookup for O(n) matching. Can you either reuse/extend
TablePrivilegeLookup or add a short comment explaining why filterTables needs
different null-catName semantics?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
