deniskuzZ commented on code in PR #6603:
URL: https://github.com/apache/hive/pull/6603#discussion_r3620420838
##########
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/HiveTransaction.java:
##########
@@ -98,7 +98,7 @@ private static MethodHandle initCleanupHandle() {
MethodHandles.privateLookupIn(BaseTransaction.class,
MethodHandles.lookup());
return lookup.findSpecial(
BaseTransaction.class,
- "cleanUpOnCommitFailure",
+ "cleanUp",
Review Comment:
please drop the reflection completely and invoke `cleanUp` directly
````
public void cleanUpOnCommitFailure() {
cleanUp();
// delete the staged metadata JSON file
deleteMetadataFile();
}
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
