arunk-kumar commented on PR #6621: URL: https://github.com/apache/hive/pull/6621#issuecomment-5043022157
Thanks for the review! Pushed a commit addressing both points: - `start()` now unconditionally starts each election candidate in its own daemon thread, so the `UncaughtExceptionHandler` fires regardless of how the context is constructed. The `startAsDaemon` builder flag and its backing field are removed since no production caller sets it to `true` and the synchronous `run()` path bypassed the abort handler. - Updated the error message in `HiveMetaStore` to distinguish election setup failures from runtime election failures. `TestLeaderElection` still passes locally: `Tests run: 4, Failures: 0, Errors: 0, Skipped: 0`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
