illiabarbashov-sketch commented on code in PR #6626:
URL: https://github.com/apache/hive/pull/6626#discussion_r3630663301
##########
beeline/pom.xml:
##########
@@ -145,11 +145,10 @@
<groupId>org.apache.hive</groupId>
<artifactId>hive-service</artifactId>
<version>${project.version}</version>
- <scope>test</scope>
<exclusions>
<exclusion>
- <groupId>log4j</groupId>
- <artifactId>log4j</artifactId>
+ <groupId>*</groupId>
+ <artifactId>*</artifactId>
Review Comment:
it is related to hive-jdbc. The issue with "No driver..." was due to the
dependency of hive-jdbc on hive-service. And hive-jdbc ads this dependecy with
excluded artifacts. As we added it only for the hive-jdbc sake, it makes sense
to me to make it consistent and not bringing any new classes into the runtime.
https://github.com/apache/hive/blob/master/jdbc/pom.xml#L61
##########
beeline/pom.xml:
##########
@@ -244,12 +243,21 @@
</goals>
<configuration>
<createDependencyReducedPom>false</createDependencyReducedPom>
- <finalName>jar-with-dependencies</finalName>
+ <finalName>beeline-standalone</finalName>
<transformers>
<transformer
implementation="com.github.edwgiz.mavenShadePlugin.log4j2CacheTransformer.PluginsCacheFileTransformer"/>
<transformer
implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
<mainClass>org.apache.hive.beeline.BeeLine</mainClass>
+ <manifestEntries>
+ <Multi-Release>true</Multi-Release>
+ </manifestEntries>
</transformer>
+ <!--
+ Without this, the java.sql.Driver service file ends up
containing only one implementation of the
Review Comment:
updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
