deniskuzZ commented on code in PR #6607:
URL: https://github.com/apache/hive/pull/6607#discussion_r3637443743
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/StringGroupConcatColCol.java:
##########
@@ -319,7 +319,16 @@ public void evaluate(VectorizedRowBatch batch) throws
HiveException {
/*
* Do careful maintenance of the outputColVector.noNulls flag.
+ *
+ * HIVE-28503: when both inputs have noNulls=true the output
vector(outV) must set true.
Review Comment:
please keep the comment concise and clear. No need to mention HIVE-28503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
