ayushtkn commented on code in PR #6633:
URL: https://github.com/apache/hive/pull/6633#discussion_r3639023215
##########
itests/qtest-iceberg/pom.xml:
##########
@@ -285,11 +285,6 @@
<groupId>org.apache.hive</groupId>
<artifactId>hive-iceberg-handler</artifactId>
</dependency>
- <dependency>
- <groupId>org.apache.hive</groupId>
- <artifactId>hive-iceberg-handler</artifactId>
- <scope>test</scope>
Review Comment:
hmm, I thought they added in compile scope because test wasn't enough, but
the test is passing with test scope as well
```
[INFO] Running
org.apache.hadoop.hive.cli.TestIcebergRESTCatalogGravitinoLlapLocalCliDriver
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 321.6
s -- in
org.apache.hadoop.hive.cli.TestIcebergRESTCatalogGravitinoLlapLocalCliDriver
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
```
Let me push to add the classifier and see if CI complains about anything
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
