rubenada commented on code in PR #6634:
URL: https://github.com/apache/hive/pull/6634#discussion_r3643946651


##########
ql/src/test/results/clientpositive/llap/join34.q.out:
##########
@@ -43,7 +43,7 @@ FROM `default`.`src`
 WHERE `key` > 100) AS `t3`) AS `t4`
 INNER JOIN (SELECT `key`, `value`
 FROM `default`.`src1`
-WHERE (`key` < 20 OR `key` > 100) AND `key` IS NOT NULL) AS `t6` ON `t4`.`key` 
= `t6`.`key`
+WHERE CAST(`key` AS DOUBLE) BETWEEN 20 AND 100 AND `key` IS NOT NULL) AS `t6` 
ON `t4`.`key` = `t6`.`key`

Review Comment:
   This unparse issue (operator unparses as "BETWEEN" instead of "NOT BETWEEN") 
will be handled in a separate follow-up ticket: 
https://issues.apache.org/jira/browse/HIVE-29765
   On the plan itself the operator is correctly represented as a "NOT BETWEEN" 
though, so no issue there (see below)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to