okumin commented on code in PR #6660:
URL: https://github.com/apache/hive/pull/6660#discussion_r3676112647
##########
itests/test-docker/src/test/java/org/apache/iceberg/rest/HiveIcebergRESTViewCatalogTests.java:
##########
@@ -57,32 +57,22 @@ protected RESTCatalog tableCatalog() {
}
@Override
- protected boolean requiresNamespaceCreate() {
- return true;
- }
-
- @Override
- protected boolean supportsServerSideRetry() {
- return true;
- }
+ protected String viewLocation(String... paths) {
+ StringBuilder location = new StringBuilder("s3a://test/test-warehouse");
+ for (String path : paths) {
+ location.append("/").append(path);
+ }
- @Override
- public void completeCreateView() {
- // This test case requires https://github.com/apache/iceberg/pull/14653
Review Comment:
We needed to disable `completeCreateView`,
`createAndReplaceViewWithLocation`, `createViewWithCustomMetadataLocation`, and
`updateViewLocation` since they hardcoded local file paths, though
`itests/test-docker` uses S3A. Now, it is pluggable, and we can run all tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
