aturoczy commented on code in PR #6652:
URL: https://github.com/apache/hive/pull/6652#discussion_r3690764672
##########
beeline/pom.xml:
##########
@@ -242,6 +242,100 @@
</dependency>
</dependencies>
<profiles>
+ <!--
+ Build a native installer (dmg on macOS, exe/msi on Windows, deb/rpm on
Linux).
+ The installer bundles a JRE — end-users need no Java pre-installed.
+
+ Usage:
+ mvn package -pl beeline -am -DskipTests -P native-installer
+
+ Output (arch sub-directory so x64 and arm64 artifacts coexist):
+ beeline/target/installer/x64/beeline-4.3.0.dmg (Intel Mac)
+ beeline/target/installer/arm64/beeline-4.3.0.dmg (Apple Silicon —
macos-arm64 auto-activates)
+ beeline/target/installer/x64/beeline-4.3.0.exe (Windows)
+ beeline/target/installer/x64/beeline_4.3.0_amd64.deb (Linux)
+
+ installer.arch defaults to x64 and is overridden to arm64 by the
+ macos-arm64 profile below when running on Apple Silicon.
+ -->
+ <profile>
+ <id>native-installer</id>
+ <properties>
+ <!-- jpackage requires version as 1-3 integers separated by dots -->
+ <installer.app.version>4.3.0</installer.app.version>
Review Comment:
Should not be the version number a parameter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
