soumyakanti3578 commented on code in PR #6636: URL: https://github.com/apache/hive/pull/6636#discussion_r3707836560
########## standalone-metastore/metastore-server/src/main/sql/oracle/rebuild-indexes.oracle.sql: ########## @@ -0,0 +1,222 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor license agreements. See the NOTICE file distributed with +-- this work for additional information regarding copyright ownership. +-- The ASF licenses this file to you under the Apache License, Version 2.0 +-- (the "License"); you may not use this file except in compliance with +-- the License. You may obtain a copy of the License at +-- +-- http://www.apache.org/licenses/LICENSE-2.0 +-- +-- Unless required by applicable law or agreed to in writing, software +-- distributed under the License is distributed on an "AS IS" BASIS, +-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +-- See the License for the specific language governing permissions and +-- limitations under the License. + + +-- Oracle has no DROP INDEX IF EXISTS; this script uses plain DROP INDEX. +-- If an index is already missing, comment out its DROP line before running. +-- Update this file whenever a new upgrade script adds an index. Review Comment: Yes, PL/SQL should work for this. I wanted to go with the simpler approach for now given that this feature would be used rarely, and maintainability of a PL/SQL script is higher. I will update the script with PL/SQL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
