hemanthumashankar0511 commented on PR #6668:
URL: https://github.com/apache/hive/pull/6668#issuecomment-5243952412
> @hemanthumashankar0511 Thank you! Would you mind if I asked you to apply
the following changes.
>
> ```diff
> diff --git a/checkstyle/checkstyle.xml b/checkstyle/checkstyle.xml
> index 306f8845a5..8448baa630 100644
> --- a/checkstyle/checkstyle.xml
> +++ b/checkstyle/checkstyle.xml
> @@ -62,6 +62,7 @@
> <module name="Translation"/>
>
> <module name="Header">
> + <property name="severity" value="error"/>
> <property name="headerFile" value="${config_loc}/asf.header"/>
> </module>
>
> diff --git a/standalone-metastore/checkstyle/checkstyle.xml
b/standalone-metastore/checkstyle/checkstyle.xml
> index f21bb3a068..0c5558a252 100644
> --- a/standalone-metastore/checkstyle/checkstyle.xml
> +++ b/standalone-metastore/checkstyle/checkstyle.xml
> @@ -62,6 +62,7 @@
> <module name="Translation"/>
>
> <module name="Header">
> + <property name="severity" value="error"/>
> <property name="headerFile" value="${config_loc}/asf.header"/>
> </module>
>
> diff --git a/storage-api/checkstyle/checkstyle.xml
b/storage-api/checkstyle/checkstyle.xml
> index a920085b9b..7fee2c5cf9 100644
> --- a/storage-api/checkstyle/checkstyle.xml
> +++ b/storage-api/checkstyle/checkstyle.xml
> @@ -62,6 +62,7 @@
> <module name="Translation"/>
>
> <module name="Header">
> + <property name="severity" value="error"/>
> <property name="headerFile" value="${config_loc}/asf.header"/>
> </module>
> ```
>
> and then to run `mvn checkstyle:check`? It will let you know the remaining
violations.
@okumin One thing I noticed, the Header module seems to expect `/*` style
comments even for `.properties` files (e.g. log4j2.properties), which isn't
valid syntax for that file type. Should these be excluded via
`fileExtensions`,
or is there a separate header format expected for non-Java files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
