architjainjain commented on code in PR #6686:
URL: https://github.com/apache/hive/pull/6686#discussion_r3764176971
##########
pom.xml:
##########
@@ -429,7 +429,62 @@
</dependency>
<dependency>
<groupId>org.graalvm.js</groupId>
- <artifactId>js</artifactId>
+ <artifactId>js-language</artifactId>
+ <version>${graalvm.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.graalvm.polyglot</groupId>
+ <artifactId>polyglot</artifactId>
+ <version>${graalvm.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.graalvm.regex</groupId>
+ <artifactId>regex</artifactId>
+ <version>${graalvm.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.graalvm.sdk</groupId>
+ <artifactId>collections</artifactId>
+ <version>${graalvm.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.graalvm.sdk</groupId>
+ <artifactId>graal-sdk</artifactId>
+ <version>${graalvm.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.graalvm.sdk</groupId>
+ <artifactId>jniutils</artifactId>
+ <version>${graalvm.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.graalvm.sdk</groupId>
+ <artifactId>nativeimage</artifactId>
+ <version>${graalvm.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.graalvm.sdk</groupId>
+ <artifactId>word</artifactId>
+ <version>${graalvm.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.graalvm.shadowed</groupId>
+ <artifactId>icu4j</artifactId>
+ <version>${graalvm.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.graalvm.truffle</groupId>
+ <artifactId>truffle-api</artifactId>
+ <version>${graalvm.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.graalvm.truffle</groupId>
+ <artifactId>truffle-compiler</artifactId>
+ <version>${graalvm.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.graalvm.truffle</groupId>
+ <artifactId>truffle-runtime</artifactId>
<version>${graalvm.version}</version>
</dependency>
Review Comment:
Thanks for the review @abstractdog! You're correct — `dependencyManagement`
alone is a no-op.
In **23.0.8**, `org.graalvm.js:js` was a monolithic JAR containing the JS
engine, pulling `graal-sdk`, `truffle-api`, `regex`, and `com.ibm.icu:icu4j`
transitively.
In **25.1.3**, `org.graalvm.js:js` is now a POM-only aggregator (no JAR).
The implementation was split into modular artifacts — `js-language` (JS
engine), `graal-sdk` (now pulls individual SDK modules), `truffle-runtime`
(pulls `truffle-api` + `truffle-compiler`), and `com.ibm.icu:icu4j` was
replaced by `org.graalvm.shadowed:icu4j`.
To cover what the old `js` JAR provided, we explicitly declared these 4
direct deps in `ql/pom.xml` with versions managed centrally via
`${graalvm.version}` in root `pom.xml`:
```xml
<dependency>org.graalvm.js:js-scriptengine</dependency>
<dependency>org.graalvm.js:js-language</dependency>
<dependency>org.graalvm.sdk:graal-sdk</dependency>
<dependency>org.graalvm.truffle:truffle-runtime</dependency>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
